Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSS preloading in Firefox #1235

Merged
merged 5 commits into from Jun 29, 2020
Merged

Fix CSS preloading in Firefox #1235

merged 5 commits into from Jun 29, 2020

Conversation

developit
Copy link
Member

This should fix #1199 - it reverts back to the old behavior, which was the critters default:

<head>
  <link href="/bundle.css" rel="preload" as="style">
</head>
<body>
  ...
  <link rel="stylesheet" href="/bundle.css">
</body>

@developit developit requested a review from prateekbh June 10, 2020 15:37
@prateekbh
Copy link
Member

Wouldn't this send us back to #1106?

@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2020

💥 No Changeset

Latest commit: dcf37c6

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@developit
Copy link
Member Author

Ah, yeah indeed it would.

@developit
Copy link
Member Author

developit commented Jun 18, 2020 •
edited

I wonder if preload:"media" would work.
It does <link rel=stylesheet media="not x" onload="this.media='all'" href="..css">.

@prateekbh prateekbh requested review from ForsakenHarmony, marvinhagemeister and reznord and removed request for prateekbh June 29, 2020 07:10
@prateekbh
Copy link
Member

removed myself from reviewers as i added a commit.

Checked on FF77 and chrome. works as expected

@marvinhagemeister marvinhagemeister merged commit cf2caec into master Jun 29, 2020
@marvinhagemeister marvinhagemeister deleted the fix-firefox-preloading branch June 29, 2020 07:56
@blenderskool blenderskool mentioned this pull request Jun 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@ForsakenHarmony ForsakenHarmony Awaiting requested review from ForsakenHarmony

@reznord reznord Awaiting requested review from reznord

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async CSS loading is broken in Firefox 77
3 participants
@developit @prateekbh @marvinhagemeister